8000 [Asset] Add type-hints to public interfaces and classes by jschaedl · Pull Request #32202 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Asset] Add type-hints to public interfaces and classes #32202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2019

Conversation

jschaedl
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR N/A

This PR adds type hints to all public interfaces of the Asset component.

@jschaedl jschaedl marked this pull request as ready for review June 26, 2019 19:28
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jun 28, 2019
@jschaedl jschaedl force-pushed the improvement/asset-type-hints branch from c171410 to 065fdc1 Compare June 29, 2019 06:09
@fabpot
Copy link
Member
fabpot commented Jun 29, 2019

Thank you @jschaedl.

@fabpot fabpot merged commit 065fdc1 into symfony:master Jun 29, 2019
fabpot added a commit that referenced this pull request Jun 29, 2019
…(jschaedl)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Asset] Add type-hints to public interfaces and classes

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32179  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

This PR adds type hints to all public interfaces of the Asset component.

Commits
-------

065fdc1 [Asset] Add type-hints to public interfaces
@jschaedl jschaedl deleted the improvement/asset-type-hints branch February 23, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0