8000 [SecurityBundle] don't validate IP addresses from env var placeholders by xabbuh · Pull Request #32115 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] don't validate IP addresses from env var placeholders #32115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

[SecurityBundle] don't validate IP addresses from env var placeholders #32115

merged 1 commit into from
Jun 20, 2019

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jun 20, 2019
Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32108
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.3 milestone Jun 20, 2019
@xabbuh xabbuh mentioned this pull request Jun 20, 2019
Closed
@xabbuh xabbuh requested a review from javiereguiluz June 20, 2019 09:54
javiereguiluz
javiereguiluz approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in this ... but changes look OK to me. Thanks Christian.

@Simperfit
Copy link
Contributor

I've tested it and it works.

@fabpot
Copy link
Member
fabpot commented Jun 20, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit f23a7f6 into symfony:4.3 Jun 20, 2019
fabpot added a commit that referenced this pull request Jun 20, 2019
@fabpot
bug #32115 [SecurityBundle] don't validate IP addresses from env var …
030396a 
…placeholders (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[SecurityBundle] don't validate IP addresses from env var placeholders

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32108
| License       | MIT
| Doc PR        |

Commits
-------

f23a7f6 don't validate IP addresses from env var placeholders
@xabbuh xabbuh deleted the issue-32108 branch June 20, 2019 11:27
@Wirone
Copy link
Contributor
Wirone commented Jun 24, 2019

When it will be available in stable release? We need this fix to upgrade our dependencies, but I prefer not to use "symfony/security-bundle": "4.3.*@dev", in our composer.json.

@xabbuh
Copy link
Member Author
xabbuh commented Jun 24, 2019

@Wirone Patch releases are published every four weeks regularly.

@fabpot fabpot mentioned this pull request Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @Simperfit @fabpot @Wirone @javiereguiluz @nicolas-grekas @carsonbot
0