Prepare for PHP 7.4 preload #32054
Merged
Prepare for PHP 7.4 preload #32054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Jun 17, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Prepare for PHP 7.4 preload | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - PHP 7.4 preloading is not compatible with declaring the same class twice in if/else blocks. Let's split the ones we have in several files. Commits ------- 7cf3fb4 Prepare for PHP 7.4 preload
| class LogicException extends \LogicException implements Psr6CacheInterface, SimpleCacheInterface | ||
| { | ||
| } | ||
| require __DIR__.\DIRECTORY_SEPARATOR.'LogicException-psr16.php'; |
There was a problem hiding this comment.
@nicolas-grekas Shouldn't this be:
require __DIR__.\DIRECTORY_SEPARATOR.'LogicException+psr16.php';There was a problem hiding this comment.
oops you're right, could you please send a PR on branch 4.4 to fix it?
There was a problem hiding this comment.
Done, I hope I did it right.
#32082
andersonamuller
added a commit
to andersonamuller/symfony
that referenced
this pull request
Jun 18, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jun 18, 2019
…muller) This PR was merged into the 4.4 branch. Discussion ---------- [CACHE] Correct required file added in #32054 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32054 | License | MIT | Doc PR | symfony/symfony-docs Just a little fix of the filename required for the preload feature. Commits ------- d04a3b3 [CACHE] Correct required file added in #32054
nicolas-grekas
added a commit
that referenced
this pull request
Jun 19, 2019
* 4.4: [FrameworkBundle] minor: fix typo in SessionTest [Debug] workaround BC break in PHP 7.3 [CACHE] Correct required file added in #32054 remove bc break code
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jun 20, 2019
fabpot
added a commit
that referenced
this pull request
Jun 20, 2019
…grekas)" (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- Revert "minor #32054 Prepare for PHP 7.4 preload (nicolas-grekas)" | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32032 | License | MIT | Doc PR | - This reverts commit a0aa941, reversing changes made to 8496003. This change is incompatible with Composer's class map generation. Commits ------- 8a1813a Revert "minor #32054 Prepare for PHP 7.4 preload (nicolas-grekas)"
fabpot
added a commit
that referenced
this pull request
Jun 20, 2019
* 4.4: Revert "minor #32054 Prepare for PHP 7.4 preload (nicolas-grekas)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.4 preloading is not compatible with declaring the same class twice in if/else blocks.
Let's split the ones we have in several files.