8000 [Cache] Add couchbase cache adapter by ajcerezo · Pull Request #32039 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Add couchbase cache adapter #32039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

[Cache] Add couchbase cache adapter #32039

merged 1 commit into from
Feb 4, 2020

Conversation

ajcerezo
Copy link
Contributor
@ajcerezo ajcerezo commented Jun 14, 2019 •
edited
Loading
Q A
Branch? 4.4 for features
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32038
License MIT
Doc PR symfony/symfony-docs#11748

Add new cache adapter to be able using Couchbase as cache system.

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 15, 2019
nicolas-grekas
nicolas-grekas reviewed Jun 15, 2019
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.
Can you ensure the .travis.yml file is configured to run the tests for the new adapter please?

@ajcerezo ajcerezo changed the title Add couchbase cache adapter. [WIP] Add couchbase cache adapter. Jun 19, 2019
@ajcerezo ajcerezo changed the title [WIP] Add couchbase cache adapter. WIP: Add couchbase cache adapter. Jun 19, 2019
@ajcerezo
Copy link
Contributor Author
ajcerezo commented Jul 4, 2019

Hi @nicolas-grekas ,
The integration tests with travis do not work, but I do not understand why it fails, since I have not changed anything in the Mailer component.
The error it gives is the following:

1) Symfony\Component\Mailer\Tests\TransportTest::testFromDsnMailgun
TypeError: Argument 4 passed to Symfony\Component\Mailer\Bridge\Mailgun\Smtp\MailgunTransport::__construct() must implement interface Psr\Log\LoggerInterface or be null, instance of Mock_EventDispatcherInterface_fc379422 given, called in /home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php on line 104
/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/vendor/symfony/mailgun-mailer/Smtp/MailgunTransport.php:25
/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php:104
/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php:58
/home/travis/build/symfony/symfony/s
8000
rc/Symfony/Component/Mailer/Tests/TransportTest.php:105

And from what I can see in the code as a fourth parameter, it is passing a mock of an LoggerInterface

Could you help me?

Thank you.

@OskarStark
Copy link
Contributor

@ajcerezo are you planing to finish this PR?

@ajcerezo
Copy link
Contributor Author

Hello @OskarStark , I am sorry for the delay in the response at this time, I only have one problem with the integration tests in travis, but it is nothing of the code that I have touched, the exact comment of this problem is just above and I do not know why I fail . If you can help me, I imagine that it has been part of one of the rebase that I had to do to merge with the latest changes in branch 4.4.

The new functionality is finished.

OskarStark
OskarStark reviewed Aug 19, 2019
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this is not a BC break, can you please update the table in the PR header, if you agree with me? Thanks 👍🏻

@ajcerezo ajcerezo changed the title WIP: Add couchbase cache adapter. Add couchbase cache adapter. Aug 21, 2019
OskarStark
OskarStark reviewed Aug 21, 2019
View reviewed changes
src/Symfony/Component/Cache/Adapter/CouchbaseBucketAdapter.php
/**
* @author Antonio Jose Cerezo Aranda <aj.cerezo@gmail.com>
*/
class CouchbaseBucketAdapter extends AbstractAdapter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can and shall we make this class final @nicolas-grekas ? Not sure right now how Symfony handles such things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OskarStark,

From what I've seen none of the other adapters is defined as final class.

@ajcerezo
Copy link
Contributor Author
ajcerezo commented Aug 27, 2019 •
edited
Loading

Hi @OskarStark,
I change BC break status in the table of header but the labels of pull request not change.

Thank you

@OskarStark
Copy link
Contributor

@nicolas-grekas can you please take care of the label and give another review here? Thanks.

@fabpot
Copy link
Member
fabpot commented Sep 25, 2019

I'd like to get an idea on the number of people in the community using couchbase before merging this PR in core.

@ajcerezo
Copy link
Contributor Author

Ok, thank you.

@OskarStark
Copy link
Contributor

I'd like to get an idea on the number of people in the community using couchbase before merging this PR in core.

I asked via Twitter: https://twitter.com/OskarStark/status/1190148688565415936

@Jeroen-Sen
Copy link

👍 (We’ll open source our Symfony-Doctrine-Couchebase integration soon.😁)

@Mrkisha
Copy link
Mrkisha commented Nov 1, 2019

👍

@mgroves
Copy link
mgroves commented Nov 1, 2019 •
edited
Loading

I'd like to get an idea on the number of people in the community using couchbase before merging this PR in core.

I asked via Twitter: https://twitter.com/OskarStark/status/1190148688565415936

I'm a DA with Couchbase. I think we'll add this PR to our monthly newsletter. In the meantime, is there anything else I can do to get this in front of Couchbase/PHP/symfony users?

Also, feel free to post a message on our PHP forum if you'd like: https://forums.couchbase.com/c/php-sdk

@fparis-sp
Copy link

👍

2 similar comments
@razvanalin
Copy link

👍

@wcarvalloalandia
Copy link

👍

@nicolas-grekas nicolas-grekas changed the title Add couchbase cache adapter. [Cache] Add couchbase cache adapter Feb 3, 2020
@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to master February 3, 2020 17:36
@fabpot
Copy link
Member
fabpot commented Feb 4, 2020

Thank you @ajcerezo.

fabpot added a commit that referenced this pull request Feb 4, 2020
@fabpot
feature #32039 [Cache] Add couchbase cache adapter (ajcerezo)
cf9f5a0 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Cache] Add couchbase cache adapter

| Q             | A
| ------------- | ---
| Branch?       | 4.4 for features
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32038
| License       | MIT
| Doc PR        | symfony/symfony-docs#11748

Add new cache adapter to be able using Couchbase as cache system.

Commits
-------

1ae7dd5 [Cache] Add couchbase cache adapter
@fabpot fabpot merged commit 1ae7dd5 into symfony:master Feb 4, 2020
@ajcerezo
Copy link
Contributor Author
ajcerezo commented Feb 4, 2020

Thanks to the all symfony community.

@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
9037
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Cache Feature Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
0