8000 [DependencyInjection] Define default priority inside service class by pcabreus · Pull Request #31943 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Define default priority inside service class #31943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

[DependencyInjection] Define default priority inside service class #31943

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e2138ad
Define default priority inside service class
pcabreus Jun 7, 2019
bd88e1e
Update YamlFileLoader.php
pcabreus Jun 10, 2019
2df617e
added ability to define an priority method for a tagged collection
pcabreus Jun 10, 2019
4fed2a3
Merge branch '4.4' into patch-1
pcabreus Jun 10, 2019
b6069b2
fixed fabbot.io code standard
pcabreus Jun 10, 2019
5498824
fixed spell
pcabreus Jun 11, 2019
8ab9cfd
compare using null
pcabreus Jun 11, 2019
f48eea9
better exception decription
pcabreus Jun 11, 2019
c021fc8
fixed some code standard
pcabreus Jun 11, 2019
2d8fd1f
fixed some code standard
pcabreus Jun 11, 2019
6b51ac5
fixed arguments order
pcabreus Jun 12, 2019
b9dd5eb
using the `tagged_iterator` instead deprecated `tagged`
pcabreus Jun 12, 2019
41f5e99
optional priority method unless you define it
pcabreus Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better exception decription 
Co-Authored-By: Valentin Udaltsov <udaltsov.valentin@gmail.com>
  • Loading branch information
@pcabreus @vudaltsov
pcabreus and vudaltsov authored Jun 11, 2019
commit f48eea91431e39a61e5dcdb9ba70bc1e32cd5d45
2 changes: 1 addition & 1 deletion src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private function findAndSortTaggedServices($tagName, ContainerBuilder $container
if (!($rpm = $r->getMethod($defaultPriorityMethod))->isStatic()) {
throw new InvalidArgumentException(
sprintf(
'Method "%s::%s()" should be static: tag "%s" on service "%s" is missing default priority method.',
'Default priority method "%s::%s()" of the "%s"-tagged collection on service "%s" must be static.',
$class,
$defaultPriorityMethod,
$tagName,
Expand Down
0