[FrameworkBundle] avoid service id conflicts with Swiftmailer #31928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31906 |
| License | MIT |
| Doc PR |
xabbuh
commented
Jun 7, 2019
| @@ -1916,7 +1916,7 @@ private function registerMailerConfiguration(array $config, ContainerBuilder $co | |||
| } | |||
|
|
|||
| $loader->load('mailer.xml'); | |||
| $container->getDefinition('mailer.transport')->setArgument(0, $config['dsn']); | |||
| $container->getDefinition('mailer.default_transport')->setArgument(0, $config['dsn']); | |||
There was a problem hiding this comment.
mailer.transport would conflict with https://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/Compiler/AddSwiftMailerTransportPass.php#L40 if $mailerId is mailer
fabpot
approved these changes
Jun 7, 2019
|
alternatively, we can update the compiler pass in MonologBundle and check the transport class there |
xabbuh
commented
Jun 7, 2019
| <argument type="service" id="messenger.default_bus" on-invalid="ignore" /> | ||
| </service> | ||
| <service id="mailer" alias="mailer.mailer" /> | ||
| <service id="Symfony\Component\Mailer\MailerInterface" alias="mailer.mailer" /> | ||
|
|
||
| <service id="mailer.transport" class="Symfony\Component\Mailer\Transport\TransportInterface"> | ||
| <service id="mailer.default_transport" class="Symfony\Component\Mailer\Transport\TransportInterface"> |
There was a problem hiding this comment.
changing the id here might cause trouble for developers who have already updated and are using this id
nicolas-grekas
approved these changes
Jun 7, 2019
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 7, 2019
…ler (xabbuh) This PR was merged into the 4.3 branch. Discussion ---------- [FrameworkBundle] avoid service id conflicts with Swiftmailer | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31906 | License | MIT | Doc PR | Commits ------- 5ce0ede avoid service id conflicts with Swiftmailer
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.