8000 [Console][Lock] Allow LockableTrait to use custom stores by stixx · Pull Request #31914 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console][Lock] Allow LockableTrait to use custom stores #31914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

[Console][Lock] Allow LockableTrait to use custom stores #31914

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
38e7a8a
[Lock] Added the ability to set a store in the LockableTrait by using…
May 30, 2019
7b375db
[Lock] Moved command name of lockable to the container register
May 30, 2019
c097950
Register default store as service to be accessible by the AddConsoleC…
Jun 6, 2019
51626d9
Revert "Register default store as service to be accessible by the Add…
Jun 17, 2019
dff0863
[Lock] Replaced method injection in AddConsoleCommandPass to register…
Jun 21, 2019
ac74dde
[Lock] Added license to LockableInterface
Jun 21, 2019
cf89732
[Lock] Added the ability to set a store in the LockableTrait by using…
May 30, 2019
300bcc8
[Lock] Moved command name of lockable to the container register
May 30, 2019
588d6d9
Register default store as service to be accessible by the AddConsoleC…
Jun 6, 2019
9605bdc
Revert "Register default store as service to be accessible by the Add…
Jun 17, 2019
c1f3749
[Lock] Replaced method injection in AddConsoleCommandPass to register…
Jun 21, 2019
bbfb8aa
[Lock] Added license to LockableInterface
Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Register default store as service to be accessible by the Add… 
…ConsoleCommandPass"

This reverts commit bd46276
  • Loading branch information
Jelle van Oosterbosch committed Jun 21, 2019
commit 9605bdc655ab3a6fc40fca8f188315404eb073a3
3 changes: 1 addition & 2 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,8 +1607,7 @@ private function registerLockConfiguration(array $config, ContainerBuilder $cont
$combinedDefinition->replaceArgument(0, $storeDefinitions);
$container->setDefinition('lock.'.$resourceName.'.store', $combinedDefinition);
} else {
$storeDefinition = new ChildDefinition($storeDefinitions[0]);
$container->setDefinition('lock.'.$resourceName.'.store', $storeDefinition);
$container->setAlias('lock.'.$resourceName.'.store', new Alias((string) $storeDefinitions[0], false));
}

// Generate factories for each resource
Expand Down
0