8000 [TwigBundle] remove legacy template dirs from iterator by Tobion · Pull Request #31823 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[TwigBundle] remove legacy template dirs from iterator #31823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Jun 3, 2019
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Some leftovers from #31667

@Tobion
Copy link
Contributor Author
Tobion commented Jun 3, 2019

Waiting on #31828 and then rebasing

@Tobion Tobion added this to the 5.0 milestone Jun 3, 2019
fabpot added a commit that referenced this pull request Jun 4, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBundle] mark TemplateIterator as internal

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This class is an implementation detail and should not be relied on as an extension point. This is also why TemplateCacheWarmer does not typhint this class but iterable. By making it internal we can remove the rootDir argument in #31823

Commits
-------

9b46c17 [TwigBundle] mark TemplateIterator as internal
@fabpot
Copy link
Member
fabpot commented Jun 4, 2019

@Tobion #31828 has been merged now.

@Tobion Tobion force-pushed the leftover-legacy-template-dirs branch 2 times, most recently from a66d16a to fdeeb81 Compare June 4, 2019 14:43
@Tobion
Copy link
Contributor Author
Tobion commented Jun 4, 2019

Rebased

@Tobion Tobion force-pushed the leftover-legacy-template-dirs branch from fdeeb81 to d1137f9 Compare June 4, 2019 15:16
fabpot
8000
@fabpot
Copy link
Member
fabpot commented Jun 5, 2019

Thank you @Tobion.

@fabpot fabpot merged commit d1137f9 into symfony:master Jun 5, 2019
fabpot added a commit that referenced this pull request Jun 5, 2019
…Tobion)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[TwigBundle] remove legacy template dirs from iterator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | yes
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Some leftovers from #31667

Commits
-------

d1137f9 [TwigBundle] remove legacy template dirs from iterator
@Tobion Tobion deleted the leftover-legacy-template-dirs branch June 5, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0