[TwigBridge] suggest Translation Component when TranslationExtension is used #31761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31754 |
| License | MIT |
| Doc PR | - |
fabpot
requested changes
May 31, 2019
| @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED); | ||
| if (null === $this->translator) { | ||
| if (!interface_exists(TranslatorInterface::class)) { | ||
| throw new \LogicException(sprintf('You cannot use the "%s" if the Translation Contracts are not available. Try running "composer require symfony/translation-contracts".', __CLASS__)); |
There was a problem hiding this comment.
What about recommending symfony/translator instead? If there are some usage of the Translation extension, it means that people want to use translation. So, they need the concrete implementation, not just the contracts.
There was a problem hiding this comment.
Why not. What's the use case for using the extension without providing it a translator?
There was a problem hiding this comment.
The only use case is for third-party bundles using translations, but that must be compatible with projects not using translations. But anyway, the main usage is when people wants to use translations, in which case, we need to recommend the implementation.
7701872 to
f294d28
Compare
f294d28 to
d4a9e7e
Compare
fabpot
approved these changes
Jun 1, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 1, 2019
…nExtension is used (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [TwigBridge] suggest Translation Component when TranslationExtension is used | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31754 | License | MIT | Doc PR | - Commits ------- d4a9e7e [TwigBridge] suggest Translation Component when TranslationExtension is used
Merged
mhujer
added a commit
to mhujer/BreadcrumbsBundle
that referenced
this pull request
Nov 23, 2019
symfony/twig-bridge 4.3.1 is needed because of symfony/symfony#31761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.