8000 [Form] Throw exception for invalid form buttons name by yceruto · Pull Request #31705 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Throw exception for invalid form buttons name #31705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2019
Merged

[Form] Throw exception for invalid form buttons name #31705

merged 1 commit into from
May 29, 2019

Conversation

@yceruto
Copy link
Member
@yceruto yceruto commented May 29, 2019
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

See #28969

@yceruto yceruto requested a review from xabbuh as a code owner May 29, 2019 18:52
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone May 29, 2019
@nicolas-grekas
Copy link
Member
nicolas-grekas commented May 29, 2019

(note: no need to create one removal PR by deprecation - grouping a bit could be easier for everyone)

@nicolas-grekas
Copy link
Member
nicolas-grekas commented May 29, 2019

(.e.g: rebase needed now :) )
8000

@yceruto
Copy link
Member Author
yceruto commented May 29, 2019

I guess that this way should be easier to review.

(.e.g: rebase needed now :) )

it's not needed here :)

@nicolas-grekas
Copy link
Member
nicolas-grekas commented May 29, 2019

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit 6deeaa4 into symfony:master May 29, 2019
nicolas-grekas added a commit that referenced this pull request May 29, 2019
@nicolas-grekas
minor #31705 [Form] Throw exception for invalid form buttons name (yc…
abc652c 
…eruto)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] Throw exception for invalid form buttons name

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See #28969

Commits
-------

6deeaa4 Validating form buttons name
@yceruto yceruto deleted the rm_form_depr3 branch May 29, 2019 19:17
@fancyweb fancyweb mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees

No one assigned

Labels

Form Status: Needs Review

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yceruto @nicolas-grekas @carsonbot
0