8000 [HttpClient] fix handling exceptions thrown before first mock chunk by nicolas-grekas · Pull Request #31610 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpClient] fix handling exceptions thrown before first mock chunk #31610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2019
Merged

[HttpClient] fix handling exceptions thrown before first mock chunk #31610

merged 1 commit into from
May 25, 2019

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Discovered while fixing a 60s timeout on a test case, which this fixes too.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 24, 2019
@nicolas-grekas nicolas-grekas changed the title [HttpClient] fix handling exceptions throw before first mock chunk [HttpClient] fix handling exceptions thrown before first mock chunk May 24, 2019
@fabpot
Copy link
Member
fabpot commented May 25, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 812b017 into symfony:4.3 May 25, 2019
fabpot added a commit that referenced this pull request May 25, 2019
@fabpot
bug #31610 [HttpClient] fix handling exceptions thrown before first m…
6aacfea 
…ock chunk (nicolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] fix handling exceptions thrown before first mock chunk

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Discovered while fixing a 60s timeout on a test case, which this fixes too.

Commits
-------

812b017 [HttpClient] fix handling exceptions thrown before first mock chunk
@nicolas-grekas nicolas-grekas deleted the hc-fix-mock branch May 28, 2019 10:30
@fabpot fabpot mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @Simperfit @carsonbot
0