8000 [Finder] fix wrong method call casing by azjezz · Pull Request #31606 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Finder] fix wrong method call casing #31606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2019
Merged

[Finder] fix wrong method call casing #31606

merged 1 commit into from
May 25, 2019

Conversation

azjezz
Copy link
Contributor
@azjezz azjezz commented May 24, 2019

fix wrong method call casing for SplFileInfo::getRealPath()

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

ro0NL
ro0NL approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor
@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more at

symfony/src/Symfony/Component/Filesystem/Filesystem.php

Line 575 in ce26936

if ($file->getPathName() === $targetDir || $file->getRealPath() === $targetDir || 0 === strpos($file->getRealPath(), $targetDirInfo->getRealPath())) {
(getPathName) 👼

@azjezz
Copy link
Contributor Author
azjezz commented May 24, 2019

@ro0NL i will open another PR for that, the statement was introduced in 4.3 ( 59437a4 ), this PR targets 3.4 👼

@azjezz
Copy link
Contributor Author
azjezz commented May 24, 2019

#31607

@fabpot
Copy link
Member
fabpot commented May 25, 2019

Good catch, thanks @azjezz.

@fabpot fabpot merged commit 9b558fe into symfony:3.4 May 25, 2019
fabpot added a commit that referenced this pull request May 25, 2019
@fabpot
minor #31606 [Finder] fix wrong method call casing (azjezz)
b647f74 
This PR was merged into the 3.4 branch.

Discussion
----------

[Finder] fix wrong method call casing

fix wrong method call casing for [`SplFileInfo::getRealPath()`](https://www.php.net/manual/en/splfileinfo.getrealpath.php)

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

9b558fe [Finder] fix wrong method call casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@ro0NL ro0NL ro0NL approved these changes

Assignees
No one assigned
Labels
Finder Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azjezz @fabpot @ro0NL @carsonbot
0