8000 [Serializer] UnwrappingDenormalizer by nonanerz · Pull Request #31390 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] UnwrappingDenormalizer #31390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2020
Merged

[Serializer] UnwrappingDenormalizer #31390

merged 1 commit into from
Apr 12, 2020

Conversation

nonanerz
Copy link
Contributor
@nonanerz nonanerz commented May 6, 2019 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

UnwrappingDenormalizer, registered with very high priority. Unwrapping the data if UNWRAP_PATH is provided.

Very often some APIs give nested responses in which we need only the child object. With UnwrappingDenormalizer we can get the needed object without creating unnecessary Model class that we don't really need.

Regarding to #28887 and #30894

Usage:

$serialiser->deserialize('{"baz": {"foo": "bar", "inner": {"title": "value", "numbers": [5,3]}}}', Object::class, ['UnwrappingDenormalizer::UNWRAP_PATH' => '[baz][inner]'])

@nonanerz nonanerz force-pushed the unwrap_denormalizer branch 2 times, most recently from 4c2eb4b to 5b757a9 Compare May 6, 2019 08:25
@nicolas-grekas nicolas-grekas added this to the next milestone May 9, 2019
@nonanerz nonanerz force-pushed the unwrap_denormalizer branch 2 times, most recently from fe55720 to 1e97075 Compare August 30, 2019 16:37
stof
stof requested changes Sep 12, 2019
View reviewed changes
Copy link
Member
@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add unit tests for the denormalizer itself.

@nonanerz nonanerz requested a review from dunglas September 13, 2019 08:17
@nonanerz nonanerz requested a review from stof September 13, 2019 08:17
@nonanerz nonanerz force-pushed the unwrap_denormalizer branch 2 times, most recently from 00aeeff to 5b9c3d8 Compare September 13, 2019 13:01
@nonanerz
UnwrappingDenormalizer
00d103d 
inject an existing instance of PropertyAccess, implement hasCacheableSupportsMethod

Coding Standard fix

resolve conversations

test denormalizer
@nonanerz nonanerz force-pushed the unwrap_denormalizer branch from f536749 to 00d103d Compare January 10, 2020 14:46
@nonanerz
Copy link
Contributor Author

Thank you for the feedback @dunglas and @stof. Now everything should be fine.

@nonanerz
Copy link
Contributor Author

Please also add unit tests for the denormalizer itself.

Hi. Can you please take a look? Waiting for your approval

@fabpot
Copy link
Member
fabpot commented Apr 12, 2020

Thank you @nonanerz.

@fabpot fabpot mentioned this pull request Apr 12, 2020
Closed
@fabpot fabpot merged commit 7c98954 into symfony:master Apr 12, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@Korbeil Korbeil mentioned this pull request Jun 2, 2020
Merged
fabpot added a commit that referenced this pull request Jun 3, 2020
@fabpot
bug #37058 [FrameworkBundle] Extension Serializer issue (Korbeil)
2a9edfa 
This PR was merged into the 5.1 branch.

Discussion
----------

[FrameworkBundle] Extension Serializer issue

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ???
| License       | MIT
| Doc PR        |

Hi,

When creating a new Symfony project and requiring `symfony/serializer` we have an issue with required service.

Here is a simple reproducer:
![image](https://user-images.githubusercontent.com/944409/83497176-6266d480-a4ba-11ea-98cb-7e354be0a273.png)

This bug was introduced by #31390

Commits
-------

ab5628f FrameworkBundle Serializer issue
hultberg pushed a commit to hultberg/symfony that referenced this pull request Sep 17, 2021
@fabpot
feature symfony#31390 [Serializer] UnwrappingDenormalizer (nonanerz)
0d866f1 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Serializer] UnwrappingDenormalizer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

UnwrappingDenormalizer, registered with very high priority. Unwrapping the data if UNWRAP_PATH is provided.

Very often some APIs give nested responses in which we need only the child object. With UnwrappingDenormalizer we can get the needed object without creating unnecessary Model class that we don't really need.

Regarding to symfony#28887 and symfony#30894

Usage:

`$serialiser->deserialize('{"baz": {"foo": "bar", "inner": {"title": "value", "numbers": [5,3]}}}', Object::class, ['UnwrappingDenormalizer::UNWRAP_PATH' => '[baz][inner]'])`

Commits
-------

00d103d UnwrappingDenormalizer
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 9, 2023
Closed
@derrabus derrabus mentioned this pull request Sep 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@maxhelias maxhelias maxhelias approved these changes

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Feature Serializer Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
7 participants
@nonanerz @fabpot @dunglas @stof @maxhelias @nicolas-grekas @carsonbot
0