[FrameworkBundle] Show injected services for iterator and array arguments #31353
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -348,12 +348,20 @@ protected function describeContainerDefinition(Definition $definition, array $op | |
| $argumentsInformation[] = sprintf('Service(%s)', (string) $argument); | ||
| } elseif ($argument instanceof IteratorArgument) { | ||
| $argumentsInformation[] = sprintf('Iterator (%d element(s))', \count($argument->getValues())); | ||
| foreach (array_map(function (Reference $value) {return (string) $value; }, $argument->getValues()) as $service) { | ||
| $argumentsInformation[] = sprintf('- %s', $service); | ||
| } | ||
| } elseif ($argument instanceof ServiceLocatorArgument) { | ||
| $argumentsInformation[] = sprintf('Service locator (%d element(s))', \count($argument->getValues())); | ||
| } elseif ($argument instanceof Definition) { | ||
| $argumentsInformation[] = 'Inlined Service'; | ||
| } else { | ||
| $argumentsInformation[] = \is_array($argument) ? sprintf('Array (%d element(s))', \count($argument)) : $argument; | ||
| if (\is_array($argument)) { | ||
| foreach (array_keys($argument) as $service) { | ||
| $argumentsInformation[] = sprintf('- %s', $service); | ||
|
There was a problem hiding this comment. I reverted this part in 7a53e8d as I don't see how listing keys can be useful. |
||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is a reference, it should be displayed as
Service(%s)fixed in 7a53e8d too