10000 [Intl] Add phpdoc by ro0NL · Pull Request #31332 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Intl] Add phpdoc #31332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2019
Merged

[Intl] Add phpdoc #31332

merged 1 commit into from
May 1, 2019

Conversation

ro0NL
Copy link
Contributor
@ro0NL ro0NL commented Apr 30, 2019
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31325 (comment)
License MIT
Doc PR symfony/symfony-docs#...

@ro0NL ro0NL mentioned this pull request Apr 30, 2019
Merged
stof
stof requested changes Apr 30, 2019
View reviewed changes
@fabpot
Copy link
Member
fabpot commented May 1, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit 22a6f7b into symfony:master May 1, 2019
fabpot added a commit that referenced this pull request May 1, 2019
@fabpot
bug #31332 [Intl] Add phpdoc (ro0NL)
48e3f40 
This PR was squashed before being merged into the 4.3-dev branch (closes #31332).

Discussion
----------

[Intl] Add phpdoc

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31325 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

22a6f7b [Intl] Add phpdoc
@ro0NL ro0NL deleted the intl-fix branch May 1, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakzal jakzal jakzal left review comments

@stof stof stof requested changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Intl Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ro0NL @fabpot @jakzal @stof @carsonbot
0