Make the email validator a hard requirement of mailer #31260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't the HTML5-regexp enough in real life? |
linaori
reviewed
Apr 27, 2019
| @@ -17,13 +17,13 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^7.1.3", | |||
| "egulias/email-validator": "^2.0", | |||
There was a problem hiding this comment.
This would add a dependency on a non-organizational repository outside of Symfony, which can cause all sorts of issues:
- Bus Factor
- Possibly slow patching of (security) bugs
- less control over releases and how fast they can be done
I don't oppose using this package as a required dependency (though I agree with nicolas' alternative), just want to make sure the above issues (and possibly others) won't cause problems.
There was a problem hiding this comment.
Swiftmailer has 110M downloads and has been using this library for years. Drupal and Laravel are also using this library.
fabpot
added a commit
that referenced
this pull request
Apr 27, 2019
…pot) This PR was merged into the 4.3-dev branch. Discussion ---------- Make the email validator a hard requirement of mailer | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes-ish | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a I think it makes sense to have the email address validator as a hard requirement of Mailer... as I don't see how you can send emails without an email address :) Commits ------- 5ad2cb1 made the email validator a hard requirement of mailer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to have the email address validator as a hard requirement of Mailer... as I don't see how you can send emails without an email address :)