8000 [FrameworkBundle] Drop unused private method by chalasr · Pull Request #31251 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Drop unused private method #31251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2019
Merged

[FrameworkBundle] Drop unused private method #31251

merged 1 commit into from
Apr 26, 2019

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Apr 25, 2019
Q A
Branch? master
Bug fix? n/a
New feature? n/a
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@chalasr chalasr added this to the next milestone Apr 25, 2019
@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 1e9a9b2 into symfony:master Apr 26, 2019
nicolas-grekas added a commit that referenced this pull request Apr 26, 2019
@nicolas-grekas
minor #31251 [FrameworkBundle] Drop unused private method (chalasr)
be80868 
This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle] Drop unused private method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | n/a
| New feature?  | n/a
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

1e9a9b2 [FrameworkBundle] Drop unused private method
@chalasr chalasr deleted the dead-code branch April 26, 2019 11:55
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @nicolas-grekas @Simperfit @carsonbot
0