8000 [TwigBridge][DependencyInjection] ignore null arguments by xabbuh · Pull Request #30992 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge][DependencyInjection] ignore null arguments #30992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2019
Merged

[TwigBridge][DependencyInjection] ignore null arguments #30992

merged 1 commit into from
Apr 8, 2019

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Apr 7, 2019
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the next milestone Apr 7, 2019
@OskarStark
Copy link
Contributor

Could you explain why in a small sentence?

@derrabus
Copy link
Member
derrabus commented Apr 7, 2019

Could you explain why in a small sentence?

The old constructor signature was (RequestStack $requestStack, RequestContext $requestContext = null), so null was a valid second argument until #30862. This PR basically restores BC.

@OskarStark
Copy link
Contributor

Ah yes I thought it on the linked PR from Valentin 👍🏻
Thanks for the feedback, it makes sense 😊

@xabbuh xabbuh changed the title [TwigBridge] ignore null arguments [TwigBridge][DependencyInjection] ignore null arguments Apr 7, 2019
@fabpot
Copy link
Member
fabpot commented Apr 8, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 44eb7a0 into symfony:master Apr 8, 2019
fabpot added a commit that referenced this pull request Apr 8, 2019
@fabpot
bug #30992 [TwigBridge][DependencyInjection] ignore null arguments (x…
02e865b 
…abbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[TwigBridge][DependencyInjection] ignore null arguments

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

44eb7a0 fix backwards compatibility breaks
@xabbuh xabbuh deleted the pr-30862 branch April 8, 2019 07:21
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr chalasr approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed TwigBridge
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
8 participants
@xabbuh @OskarStark @derrabus @fabpot @chalasr @maxhelias @nicolas-grekas @carsonbot
0