8000 Allow env processor to resolve `::` by jderusse · Pull Request #30990 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Allow env processor to resolve :: #30990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

Allow env processor to resolve :: #30990

merged 1 commit into from
Apr 7, 2019

Conversation

jderusse
Copy link
Member
@jderusse jderusse commented Apr 7, 2019
Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR N/A

The env processor resolve to null when no fallback are provided. ie. env(default::NOT_EXISTS)

Issue is that the regexp does not allow such pattern. thus made the feature unusable.

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 7, 2019
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 6b6c24c into symfony:master Apr 7, 2019
nicolas-grekas added a commit that referenced this pull request Apr 7, 2019
@nicolas-grekas
bug #30990 Allow env processor to resolve :: (jderusse)
408e4aa 
This PR was merged into the 4.3-dev branch.

Discussion
----------

Allow env processor to resolve `::`

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | N/A

The env processor resolve to null when no fallback are provided. ie. `env(default::NOT_EXISTS)`

Issue is that the regexp does not allow such pattern. thus made the feature unusable.

Commits
-------

6b6c24c Allow env processor to resolve `::`
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@jderusse jderusse deleted the fix-default-env branch August 2, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @nicolas-grekas @carsonbot
0