[Form] Added an AbstractChoiceLoader #30983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6873075 to
6f3332f
Compare
6f3332f to
82e1931
Compare
HeahDude
commented
Apr 7, 2019
|
|
||
| if ($value) { | ||
| // if a value callback exists, use it | ||
| return array_map($value, $choices); |
There was a problem hiding this comment.
This is actually a new optimisation that will make some good when using choice_value option :)
fabpot
reviewed
Apr 8, 2019
| public function loadValuesForChoices(array $choices, $value = null) | ||
| { | ||
| // Optimize | ||
| if (empty($choices)) { |
There was a problem hiding this comment.
Some implementations use $values = array_filter($values); before the test. Is it something we can/want to add here?
There was a problem hiding this comment.
It happens that an empty value may be a valid choice for any choice list, but we know it's not the case with intl base choice types, this is why we optimized their loaders specifically.
| public function loadChoicesForValues(array $values, $value = null) | ||
| { | ||
| // Optimize | ||
| if (empty($values)) { |
|
@HeahDude What's the status of this PR? Are you willing to finish it? |
1 task
|
Taking over in #33218 |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2020
…mentations and handle global optimizations (HeahDude) This PR was merged into the 5.1-dev branch. Discussion ---------- [Form] Added an AbstractChoiceLoader to simplify implementations and handle global optimizations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Taking over #33218 (taking over #30983) The `ChoiceLoaderInterface` is not easy to understand/implement, while its goal is simple, lazy load an array of choices. What may seem complicated is the how/what to optimize loading, we need to deal with a `$value` callback (which refers to the `choice_value` option allowing to transform a model choice to a unique string value that can be displayed/submitted). We have now enough implementations in core to justify the need of an abstraction and provide a better DX in the process. Before this PR we needed to implement 3 methods to create a loader: - `loadChoiceList(?callable $value): ChoiceListInterface` - `loadChoicesForValues(array $values, ?callable $value): array` - `loadValuesForChoices(array $choices, ?callable $value): array` and handle optimization, in each. Now we only need to implement: - `loadChoices(): iterable` and optionnally: - `doLoadChoicesForValues(array $values, ?callable $value): array` if more optimization is needed to only load submitted values, (i.e the core intl loader prevents loading values that are the same as choices, and the doctrine one performs a `WHERE id IN ($ids)` query). Commits ------- 1394df2 [Form] Added an AbstractChoiceLoader to simplify implementations and handle global optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #30962 and #30966.
Based on #30966 , only review lat commit until it is merged.#EUFOSSA