Prepare for the new serialization mechanism #30965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
999800a to
c4ce96e
Compare
fabpot
added a commit
to twigphp/Twig
that referenced
this pull request
Apr 7, 2019
This PR was merged into the 1.x branch. Discussion ---------- Prepare for the new serialization mechanism #eufossa related to symfony/symfony#30965 So we are future proof and it will prevent deprecations for symfony/symfony#30304. Almost future proof actually because the void return type cannot be added in 7.0. I guess we can see the minimum required PHP version here once 7.4 is out and see how we can handle compatibility 😕 Commits ------- 72d7abe Prepare for the new serialization mechanism
fabpot
requested changes
Apr 7, 2019
UPGRADE-4.3.md
Outdated
| @@ -133,15 +133,15 @@ Security | |||
|
|
|||
| After: | |||
| ```php | |||
| protected function getState(): array | |||
| protected function __serialize(): array | |||
There was a problem hiding this comment.
The methods are going to be public in PHP, so we should do the same here and probably mark the methods as @internal for now (that's what I've done in the Mime component).
There was a problem hiding this comment.
actually, we cannot really make them internal when the class allows extensibility by inheritance, because that's the only way to add extra data to serialized payloads
There was a problem hiding this comment.
Just updated all the forgotten protected to public 😅
nicolas-grekas
approved these changes
Apr 7, 2019
c4ce96e to
d412e77
Compare
maxhelias
approved these changes
Apr 7, 2019
fabpot
approved these changes
Apr 8, 2019
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Apr 8, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- Prepare for the new serialization mechanism | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - #eufossa Should I maybe split this component by component ? https://wiki.php.net/rfc/custom_object_serialization has been accepted. Best viewed in "split" mode. This work is kind of required for #30304 so we don't trigger 30 deprecations from our own code base. Commits ------- d412e77 Prepare for the new serialization mechanism
chalasr
pushed a commit
that referenced
this pull request
Apr 10, 2019
…tion mechanism (fancyweb) This PR was merged into the 4.3-dev branch. Discussion ---------- [Security][TokenInterface] Prepare for the new serialization mechanism | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Continuation of #30965 Commits ------- e6455ea [Security][TokenInterface] Prepare for the new serialization mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#eufossa
Should I maybe split this component by component ?
https://wiki.php.net/rfc/custom_object_serialization has been accepted.
Best viewed in "split" mode.
This work is kind of required for #30304 so we don't trigger 30 deprecations from our own code base.