8000 [TwigBundle][TwigBridge] Improving deprecation message of the legacy Twig template directory by yceruto · Pull Request #30952 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBundle][TwigBridge] Improving deprecation message of the legacy Twig template directory #30952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

[TwigBundle][TwigBridge] Improving deprecation message of the legacy Twig template directory #30952

merged 1 commit into from
Apr 7, 2019

Conversation

yceruto
Copy link
Member
@yceruto yceruto commented Apr 7, 2019 •
edited
Loading
Q A
Branch? 4.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #30088
License MIT

#eu-fossa

@yceruto yceruto mentioned this pull request Apr 7, 2019
Closed
@yceruto yceruto force-pushed the twig_directory_deprecation branch from 3be323a to 0edfaca Compare April 7, 2019 08:12
@yceruto
Copy link
Member Author
yceruto commented Apr 7, 2019

Updating tests

@yceruto yceruto force-pushed the twig_directory_deprecation branch 3 times, most recently from e6db350 to 5cf238f Compare April 7, 2019 08:32
xabbuh
xabbuh reviewed Apr 7, 2019
View reviewed changes
@yceruto yceruto force-pushed the twig_directory_deprecation branch from 5cf238f to 89a00b3 Compare April 7, 2019 08:37
@yceruto
Copy link
Member Author
yceruto commented Apr 7, 2019

Comments addressed, thank you @xabbuh

xabbuh
xabbuh approved these changes Apr 7, 2019
View reviewed changes 8000
@fabpot
Copy link
Member
fabpot commented Apr 7, 2019

Thank you @yceruto.

@fabpot fabpot merged commit 89a00b3 into symfony:4.2 Apr 7, 2019
fabpot added a commit that referenced this pull request Apr 7, 2019
@fabpot
minor #30952 [TwigBundle][TwigBridge] Improving deprecation message o…
ff3649b 
…f the legacy Twig template directory (yceruto)

This PR was merged into the 4.2 branch.

Discussion
----------

[TwigBundle][TwigBridge] Improving deprecation message of the legacy Twig template directory

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #30088
| License       | MIT

#eu-fossa

Commits
-------

89a00b3 Improving deprecation message of the Twig templates directory src/Resources/views
@yceruto yceruto deleted the twig_directory_deprecation branch April 7, 2019 08:42
@xabbuh xabbuh added this to the 4.2 milestone Apr 7, 2019
@xabbuh xabbuh mentioned this pull request Apr 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Deprecation Status: Reviewed TwigBridge TwigBundle
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@yceruto @fabpot @xabbuh @carsonbot
0