[Routing][ObjectRouteLoader] Allow invokable route loader services #30933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Apr 6, 2019
db1a736 to
13ad1d0
Compare
13ad1d0 to
5bf7ad4
Compare
nicolas-grekas
approved these changes
Apr 7, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 7, 2019
…der services (fancyweb) This PR was merged into the 4.3-dev branch. Discussion ---------- [Routing][ObjectRouteLoader] Allow invokable route loader services | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#11333 #eufossa Fall back by default on the `__invoke` method when it is not configured. Using a regex is easier to check that the format is valid, at least for the time we have to supports the single column notation. TODO : - [x] Changelog entry - [x] Doc PR Commits ------- 5bf7ad4 [Routing][ObjectRouteLoader] Allow invokable route loader services
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 7, 2019
This PR was merged into the master branch. Discussion ---------- [Routing] Invokable route loader services #eufossa doc for symfony/symfony#30933 Also the notation with one column has been deprecated so I updated this part as well. Commits ------- d9b4121 [Routing] Invokable route loader services
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#eufossa
Fall back by default on the
__invokemethod when it is not configured.Using a regex is easier to check that the format is valid, at least for the time we have to supports the single column notation.
TODO :