8000 [Profiler] Update ProfilerController.php by error56 · Pull Request #30916 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Profiler] Update ProfilerController.php #30916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2019
Merged

[Profiler] Update ProfilerController.php #30916

merged 1 commit into from
Apr 6, 2019

Conversation

error56
Copy link
Contributor
@error56 error56 commented Apr 6, 2019
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR symfony/symfony-docs#...

curry684
curry684 suggested changes Apr 6, 2019
View reviewed changes
Copy link
Contributor
@curry684 curry684 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must revert breaking change

@fabpot
Copy link
Member
fabpot commented Apr 6, 2019

Thank you @error56.

@fabpot fabpot merged commit 6e0785f into symfony:master Apr 6, 2019
fabpot added a commit that referenced this pull request Apr 6, 2019
@fabpot
minor #30916 [Profiler] Update ProfilerController.php (error56)
f587944 
This PR was squashed before being merged into the 4.3-dev branch (closes #30916).

Discussion
----------

[Profiler] Update ProfilerController.php

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

6e0785f [Profiler] Update ProfilerController.php
@nicolas-grekas nicolas-grekas added this to the next milestone Apr 7, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curry684 curry684 curry684 approved these changes

Assignees
No one assigned
Labels
Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@error56 @fabpot @curry684 @nicolas-grekas @carsonbot
0