8000 [Workflow] Fixed initial places when no places are configured by lyrixx · Pull Request #30884 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Workflow] Fixed initial places when no places are configured #30884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2019
Merged

[Workflow] Fixed initial places when no places are configured #30884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Workflow] Fixed initial places when no places are configured 
I introduced a BC break in #30468 and this PR fix it.
With the full stack framework, when one does not configure the
initial_place(s) the DIC set `[]` for the initial values.
So it removes the initials values guessed in `Definition::addPlace()`
  • Loading branch information
@lyrixx
lyrixx committed Apr 6, 2019
commit 76fd9c35b70db958370da39d88a0d7bd278a8b4a
2 changes: 1 addition & 1 deletion src/Symfony/Component/Workflow/Definition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function getMetadataStore(): MetadataStoreInterface

private function setInitialPlaces($places = null)
{
if (null === $places) {
if (!$places) {
return;
}

Expand Down
0