8000 [Messenger] Add `psr/cache` on Messenger's dependencies by sroze · Pull Request #30802 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Add psr/cache on Messenger's dependencies #30802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2019
Merged

[Messenger] Add psr/cache on Messenger's dependencies #30802

merged 1 commit into from
Mar 31, 2019

Conversation

sroze
Copy link
Contributor
@sroze sroze commented Mar 31, 2019
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30754
License MIT
Doc PR ø

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 31, 2019
@nicolas-grekas
Copy link
Member

It it really a mandatory requirement? Or just something you need if you use the related features?
2nd choice means there is not need to do this.

@fabpot
Copy link
Member
fabpot commented Mar 31, 2019

@nicolas-grekas is right.

@sroze
Copy link
Contributor Author
sroze commented Mar 31, 2019

@nicolas-grekas the way we merged #30754 means that it's a technical requirement but it's a good shot actually.

@nicolas-grekas
Copy link
Member

Not unless you use StopWorkersCommand, which you don't have to.
For require-dev if we have tests.

@sroze sroze force-pushed the add-psr-cache-to-messenger-deps branch from cc94007 to 0b5004f Compare March 31, 2019 17:23
@sroze
Copy link
Contributor Author
sroze commented Mar 31, 2019

Moved to require-dev, thanks!

@fabpot
Copy link
Member
fabpot commented Mar 31, 2019

Thank you @sroze.

@fabpot fabpot merged commit 0b5004f into symfony:master Mar 31, 2019
fabpot added a commit that referenced this pull request Mar 31, 2019
@fabpot
minor #30802 [Messenger] Add psr/cache on Messenger's dependencies …
c54a6a2 
…(sroze)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Add `psr/cache` on Messenger's dependencies

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30754
| License       | MIT
| Doc PR        | ø

Commits
-------

0b5004f Add `psr/cache` on Messenger's dependencies
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@sroze @nicolas-grekas @fabpot @chalasr @carsonbot
0