10000 [HttpClient] use "nyholm/psr7" by default in Psr18Client by nicolas-grekas · Pull Request #30752 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpClient] use "nyholm/psr7" by default in Psr18Client #30752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

[HttpClient] use "nyholm/psr7" by default in Psr18Client #30752

merged 1 commit into from
Mar 28, 2019

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This makes the factory arguments of Psr18Client optional, with a fallback to using Nyholm\Psr7\Factory\Psr17Factory when no factories are provided.

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 28, 2019
Nyholm
Nyholm approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice way to provide a simpler way to create the PSR18Client.

@nicolas-grekas nicolas-grekas merged commit f2222e4 into symfony:master Mar 28, 2019
nicolas-grekas added a commit that referenced this pull request Mar 28, 2019
@nicolas-grekas
feature #30752 [HttpClient] use "nyholm/psr7" by default in Psr18Clie…
162d5a8 
…nt (nicolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient] use "nyholm/psr7" by default in Psr18Client

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This makes the factory arguments of `Psr18Client` optional, with a fallback to using `Nyholm\Psr7\Factory\Psr17Factory` when no factories are provided.

Commits
-------

f2222e4 [HttpClient] use "nyholm/psr7" by default in Psr18Client
@nicolas-grekas nicolas-grekas deleted the psr18 branch March 28, 2019 16:45
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Feature HttpClient Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @Nyholm @javiereguiluz @carsonbot
0