Changing messenger bus id from 'message_bus' to 'messenger.default_bus' #30690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't need it due to the experimental, but do we want a BC layer here? |
|
👍 for adding BC layer |
|
We don't need a BC layer, but we definitely need some documentation in the CHANGELOG to help people migrate their code. |
|
Why not We already have:
|
|
Personally, I do like |
|
I'd add a BC layer as well, especially given the fact we have all these one-word services in Symfony ( |
|
The bc layer is a one liner: a deprecated alias should do it. |
|
@ktherage can you do these two changes (BC layer + |
dc50758 to
7e2d52c
Compare
ktherage
added a commit
to ktherage/symfony
that referenced
this pull request
Apr 1, 2019
…enger.message_bus'
|
@sroze i made the wanted changes but i'm not really sure that changes about the BC layer are those you wanted. Feel free to tell me what's wrong (on Slack i am more reactive because i get noticed as soon as i got a message). |
chalasr
reviewed
Apr 1, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.php
Outdated
Show resolved
Hide resolved
7e2d52c to
0f69c18
Compare
ktherage
added a commit
to ktherage/symfony
that referenced
this pull request
Apr 1, 2019
…enger.default_bus'
0f69c18 to
16f5711
Compare
ktherage
added a commit
to ktherage/symfony
that referenced
this pull request
Apr 1, 2019
…enger.default_bus'
|
@ktherage check the tests - one is failing now :) |
|
@weaverryan yes sorry 😅. i'll fix it. |
…enger.default_bus'
16f5711 to
3cee1ca
Compare
chalasr
approved these changes
Apr 1, 2019
fabpot
approved these changes
Apr 1, 2019
|
Thank you @ktherage. |
fabpot
added a commit
that referenced
this pull request
Apr 1, 2019
…nger.default_bus' (THERAGE Kévin) This PR was merged into the 4.3-dev branch. Discussion ---------- Changing messenger bus id from 'message_bus' to 'messenger.default_bus' Changing messenger bus tag from 'message_bus' to 'messenger.message_bus' | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | Maybe | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30670 | License | MIT | Doc PR | All is in the title. This PR change the tag of the default bus from 'message_bus' to 'messenger.message_bus'. Commits ------- 3cee1ca #30690 - Changing messenger bus id from 'message_bus' to 'messenger.default_bus'
nicolas-grekas
added a commit
that referenced
this pull request
May 5, 2019
…e_bus' to 'messenger.default_bus' (Koc) This PR was merged into the 4.3-dev branch. Discussion ---------- [Mailer][Messenger] Changing messenger bus id from 'message_bus' to 'messenger.default_bus' | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30690 | License | MIT | Doc PR | - Follow up of #30690 Commits ------- d3079e0 Changing messenger bus id from 'message_bus' to 'messenger.default_bus'
Merged
ktherage
added a commit
to ktherage/symfony
that referenced
this pull request
May 9, 2019
…enger.default_bus'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid
2CB9
suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing messenger bus tag from 'message_bus' to 'messenger.message_bus'
All is in the title.
This PR change the tag of the default bus from 'message_bus' to 'messenger.message_bus'.