8000 [Messenger] Add a BC layer for the `ConsumeMessagesCommand` arguments by sroze · Pull Request #30659 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Add a BC layer for the ConsumeMessagesCommand arguments #30659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2019
Merged

[Messenger] Add a BC layer for the ConsumeMessagesCommand arguments #30659

merged 1 commit into from
Mar 23, 2019

Conversation

sroze
Copy link
Contributor
@sroze sroze commented Mar 23, 2019
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no - removing some
Deprecations? yes (files already updated in previous PR)
Tests pass? yes
Fixed tickets ø
License MIT
Doc PR ø

Instead of conflicting symfony/messenger with an old symfony/framework-bundle, let's add a simple BC layer.

@sroze sroze force-pushed the bc-layer-for-consume-message-command branch from b46c230 to 2123531 Compare March 23, 2019 15:35
@sroze sroze requested a review from weaverryan March 23, 2019 15:36
@chalasr
Copy link
Member
chalasr commented Mar 23, 2019

Should we also rename the class to ConsumeCommand to match the new command name btw?

@fabpot
Copy link
Member
fabpot commented Mar 23, 2019

Thank you @sroze.

@fabpot fabpot merged commit 2123531 into symfony:master Mar 23, 2019
fabpot added a commit that referenced this pull request Mar 23, 2019
@fabpot
minor #30659 [Messenger] Add a BC layer for the `ConsumeMessagesComma…
468bca8 
…nd` arguments (sroze)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Add a BC layer for the `ConsumeMessagesCommand` arguments

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no - removing some
| Deprecations? | yes (files already updated in previous PR)
| Tests pass?   | yes
| Fixed tickets | ø
| License       | MIT
| Doc PR        | ø

Instead of conflicting `symfony/messenger` with an old `symfony/framework-bundle`, let's add a simple BC layer.

Commits
-------

2123531 Add a BC layer for the `ConsumeMessagesCommand` arguments
@sroze sroze deleted the bc-layer-for-consume-message-command branch March 24, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

@weaverryan weaverryan Awaiting requested review from weaverryan

Assignees
No one assigned
Labels
Bug Deprecation Messenger Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sroze @chalasr @fabpot @carsonbot
0