8000 [Cache] Only delete one key at a time when on Predis + Cluster by andrerom · Pull Request #30515 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Only delete one key at a time when on Predis + Cluster #30515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2019
Merged

[Cache] Only delete one key at a time when on Predis + Cluster #30515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Cache] Only delete one key at a time when on Predis + Cluster
  • Loading branch information
@andrerom
andrerom committed Mar 11, 2019
commit f5ece20a8397c97156ab998e7fd351d8833ad59d
12 changes: 11 additions & 1 deletion src/Symfony/Component/Cache/Traits/RedisTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,17 @@ protected function doClear($namespace)
*/
protected function doDelete(array $ids)
{
if ($ids) {
if (!$ids) {
return true;
}

if ($this->redis instanceof \Predis\Client && $this->redis->getConnection() instanceof ClusterInterface) {
$this->pipeline(function () use ($ids) {
foreach ($ids as $id) {
yield 'del' => [$id];
}
})->rewind();
} else {
$this->redis->del($ids);
}

Expand Down
0