8000 [TwigBridge] Fix DebugCommand when chain loader is involved by yceruto · Pull Request #30440 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] Fix DebugCommand when chain loader is involved #30440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

[TwigBridge] Fix DebugCommand when chain loader is involved #30440

merged 1 commit into from
Mar 20, 2019

Conversation

yceruto
Copy link
Member
@yceruto yceruto commented Mar 4, 2019 •
edited
Loading
Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30426
License MIT

Better diff: https://github.com/symfony/symfony/pull/30440/files?utf8=%E2%9C%93&diff=unified&w=1

@yceruto yceruto mentioned this pull request Mar 4, 2019
Closed
yceruto
yceruto commented Mar 4, 2019
View reviewed changes
ro0NL
ro0NL reviewed Mar 4, 2019
View reviewed changes
@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Mar 4, 2019
@yceruto yceruto marked this pull request as ready for review March 12, 2019 13:58
@fabpot
Copy link
Member
fabpot commented Mar 20, 2019

Thank you @yceruto.

@fabpot fabpot merged commit f647b4a into symfony:4.2 Mar 20, 2019
fabpot added a commit that referenced this pull request Mar 20, 2019
@fabpot
bug #30440 [TwigBridge] Fix DebugCommand when chain loader is involve…
2de59a1 
…d (yceruto)

This PR was merged into the 4.2 branch.

Discussion
----------

[TwigBridge] Fix DebugCommand when chain loader is involved

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30426
| License       | MIT

Better diff: https://github.com/symfony/symfony/pull/30440/files?utf8=%E2%9C%93&diff=unified&w=1

Commits
-------

f647b4a Fix DebugCommand when chain loader is involved
stof
stof reviewed Mar 20, 2019
View reviewed changes
@yceruto yceruto deleted the fix_30426 branch March 20, 2019 15:34
@yceruto yceruto mentioned this pull request Mar 20, 2019
Merged
fabpot added a commit that referenced this pull request Mar 20, 2019
@fabpot
bug #30616 Fix case when multiple loaders are providing paths for the…
b296860 
… same namespace (yceruto)

This PR was merged into the 4.2 branch.

Discussion
----------

Fix case when multiple loaders are providing paths for the same namespace

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT

Fixes @stof #30440 (comment)

Let me know if a test case is necessary for this.

Cheers!

Commits
-------

393d728 Fix case when multiple loaders are providing paths for the same namespace
@fabpot fabpot mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@ro0NL ro0NL ro0NL left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed TwigBridge
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@yceruto @fabpot @stof @ro0NL @nicolas-grekas @carsonbot
0