8000 [VarDumper] fix dumping Ds maps and pairs by nicolas-grekas · Pull Request #30349 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] fix dumping Ds maps and pairs #30349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2019
Merged

[VarDumper] fix dumping Ds maps and pairs #30349

merged 1 commit into from
Feb 23, 2019

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Fixes #30311 (comment)

image

@nicolas-grekas nicolas-grekas added this to the next milestone Feb 22, 2019
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 22, 2019
Merged
@nicolas-grekas nicolas-grekas force-pushed the vd-nohandle branch 2 times, most recently from cf1641e to ee20ef6 Compare February 22, 2019 19:56
enumag
enumag reviewed Feb 22, 2019
View reviewed changes
@enumag
Copy link
Contributor
enumag commented Feb 22, 2019

Thanks for this @nicolas-grekas!

@fabpot
Copy link
Member
fabpot commented Feb 23, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 45869ac into symfony:master Feb 23, 2019
fabpot added a commit that referenced this pull request Feb 23, 2019
@fabpot
bug #30349 [VarDumper] fix dumping Ds maps and pairs (nicolas-grekas)
2e8bf33 
This PR was merged into the 4.3-dev branch.

Discussion
----------

[VarDumper] fix dumping Ds maps and pairs

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fixes #30311 (comment)

![image](https://user-images.githubusercontent.com/243674/53267273-41260e80-36e3-11e9-8723-a73bf0690a01.png)

Commits
-------

45869ac [VarDumper] fix dumping Ds maps and pairs
@keksa
Copy link
Contributor
keksa commented Feb 25, 2019

Thank you @nicolas-grekas! I can confirm this fixes the original problem we had as well.

@nicolas-grekas nicolas-grekas deleted the vd-nohandle branch February 27, 2019 13:51
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@enumag enumag enumag approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed VarDumper
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @enumag @fabpot @keksa @carsonbot
0