[VarDumper] dump Closures' parameters once: in their signatures #30295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Feb 18, 2019
stof
approved these changes
Feb 18, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Feb 19, 2019
…natures (nicolas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [VarDumper] dump Closures' parameters once: in their signatures | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | not really | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Now that closures are dumped with their signature, dumping parameters is noisy duplicate info. Commits ------- f3659b6 [VarDumper] dump Closures' parameters once: in their signatures
nicolas-grekas
added a commit
that referenced
this pull request
Feb 19, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Form] Fix describing closures | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Fixes Form' TextDescriptorTest broken after #30295 Commits ------- 005e75c [Form] Fix describing closures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that closures are dumped with their signature, dumping parameters is noisy duplicate info.