8000 [Validator] Added missing use statement for UnexpectedTypeException by devrck · Pull Request #30273 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Validator] Added missing use statement for UnexpectedTypeException #30273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

devrck
Copy link
Contributor
@devrck devrck commented Feb 16, 2019
Q A
Branch? 4.2 (be careful when merging)
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Added a simple use statement that I saw it was not added, can't elaborate more than that 😄 .

Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 4.2.

@chalasr chalasr force-pushed the countvalidator-missing-use-statement branch from 42a5fba to d10347f Compare February 16, 2019 21:59
@chalasr chalasr changed the base branch from master to 4.2 February 16, 2019 21:59
@chalasr
Copy link
Member
chalasr commented Feb 16, 2019

Good catch, thanks @devrck.

@chalasr chalasr merged commit d10347f into symfony:4.2 Feb 16, 2019
chalasr pushed a commit that referenced this pull request Feb 16, 2019
…Exception (devrck)

This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #30273).

Discussion
----------

[Validator] Added missing use statement for UnexpectedTypeException

| Q             | A
| ------------- | ---
| Branch?       | 4.2 (be careful when merging)
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Added a simple use statement that I saw it was not added, can't elaborate more than that 😄 .

Commits
-------

d10347f [Validator] Added missing use statement for UnexpectedTypeException
@fabpot fabpot mentioned this pull request Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0