8000 Remove "internal" annotation from datacollector serialization methods by nicolas-grekas · Pull Request #30112 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove "internal" annotation from datacollector serialization methods #30112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Remove "internal" annotation from datacollector serialization methods #30112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove "internal" annotation from datacollector serialization methods
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Feb 8, 2019
commit 3c8fd2072f69d8f131610c6b3847505e7b9e29dd
3 changes: 0 additions & 3 deletions src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,6 @@ public function getData()
return $this->data;
}

/**
* @internal
*/
public function serialize()
{
if ($this->hasVarDumper) {
Expand Down
6 changes: 0 additions & 6 deletions src/Symfony/Component/HttpKernel/DataCollector/DataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ abstract class DataCollector implements DataCollectorInterface, \Serializable
*/
private $cloner;

/**
* @internal
*/
public function serialize()
{
$trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 2);
Expand All @@ -51,9 +48,6 @@ public function serialize()
return $isCalledFromOverridingMethod ? $this->data : serialize($this->data);
}

/**
* @internal
*/
public function unserialize($data)
{
$this->data = \is_array($data) ? $data : unserialize($data);
Expand Down
6 changes: 0 additions & 6 deletions src/Symfony/Component/HttpKernel/DataCollector/DumpDataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,6 @@ public function reset()
$this->clonesIndex = 0;
}

/**
* @internal
*/
public function serialize()
{
if ($this->clonesCount !== $this->clonesIndex) {
Expand All @@ -198,9 +195,6 @@ public function serialize()
return $ser;
}

/**
* @internal
*/
public function unserialize($data)
{
$this->data = unserialize($data);
Expand Down
0