-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[VarDumper] Fixed search bar #29984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[VarDumper] Fixed search bar #29984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this ❤️
Shouldn't we merge this one on an older branch? |
Is it possible to disable this search bar in general? |
nicolas-grekas
approved these changes
Jan 27, 2019
Thank you @ro0NL. |
8000
nicolas-grekas
added a commit
that referenced
this pull request
Jan 27, 2019
This PR was squashed before being merged into the 4.2 branch (closes #29984). Discussion ---------- [VarDumper] Fixed search bar | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continuation of #28854, replaces #29176 initial:  ctrl f:  scroll:  tested in chrome+ff cc @ogizanagi ref https://caniuse.com/#feat=css-sticky Commits ------- 99d2893 [VarDumper] Fixed search bar
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #28854, replaces #29176
initial:
ctrl f:
scroll:
tested in chrome+ff
cc @ogizanagi
ref https://caniuse.com/#feat=css-sticky