8000 Move from array() to [] by fabpot · Pull Request #29903 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Move from array() to [] #29903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 16, 2019
Merged

Move from array() to [] #29903

merged 9 commits into from
Jan 16, 2019

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jan 16, 2019
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jan 16, 2019
@fabpot fabpot changed the title Cs fix arrays Move from array() to [] Jan 16, 2019
@fabpot fabpot merged commit 37ab4cd into symfony:3.4 Jan 16, 2019
fabpot added a commit that referenced this pull request Jan 16, 2019
@fabpot
minor #29903 Move from array() to [] (fabpot)
b6b5976 
This PR was squashed before being merged into the 3.4 branch (closes #29903).

Discussion
----------

Move from array() to []

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

37ab4cd fixed CS
1429267 fixed short array CS in comments
2524083 fixed CS in ExpressionLanguage fixtures
ec7dcb2 fixed CS in generated files
afaa13e fixed CS on generated container files
7ffd8d3 fixed CS on Form PHP templates
0ba1acc fixed CS on YAML fixtures
ac9d6cf fixed fixtures
33a001e switched array() to []
@ostrolucky ostrolucky mentioned this pull request Jan 16, 2019
Closed
@fabpot fabpot deleted the cs-fix-arrays branch January 17, 2019 07:08
@derrabus derrabus mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fabpot @nicolas-grekas @carsonbot
0