10000 [HttpFoundation] MemcachedSessionHandler::close() must close connection by grachevko · Pull Request #29783 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] MemcachedSessionHandler::close() must close connection #29783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2019
Merged

[HttpFoundation] MemcachedSessionHandler::close() must close connection #29783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Bugfix] MemcachedSessionHandler::close() must close connection
  • Loading branch information
@grachevko
grachevko committed Jan 6, 2019
commit 38a9d8b6a3d4abdcb560052889eb4d7c41743c14
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcachedSessionHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function __construct(\Memcached $memcached, array $options = array())
*/
public function close()
{
return true;
return $this->memcached->quit();
}

/**
Expand Down
6 changes: 6 additions & 0 deletions ...ny/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ public function testOpenSession()

public function testCloseSession()
{
$this->memcached
->expects($this->once())
->method('quit')
->will($this->returnValue(true))
;

$this->assertTrue($this->storage->close());
}

Expand Down
0