8000 [Form] Fix FormDefaultChoiceListFactory test by vudaltsov · Pull Request #29769 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fix FormDefaultChoiceListFactory test #29769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

[Form] Fix FormDefaultChoiceListFactory test #29769

merged 1 commit into from
Jan 4, 2019

Conversation

vudaltsov
Copy link
Contributor
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29731 (review)
License MIT
Doc PR n/a

$groupBy is either null or callable. Passing array() is wrong.

@vudaltsov vudaltsov mentioned this pull request Jan 3, 2019
Closed
@fabpot
Copy link
Member
fabpot commented Jan 4, 2019

Thank you @vudaltsov.

@fabpot fabpot merged commit b8f6390 into symfony:3.4 Jan 4, 2019
fabpot added a commit that referenced this pull request Jan 4, 2019
@fabpot
minor #29769 [Form] Fix FormDefaultChoiceListFactory test (vudaltsov)
a1c8da0 
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Fix FormDefaultChoiceListFactory test

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29731 (review)
| License       | MIT
| Doc PR        | n/a

`$groupBy` is either `null` or `callable`. Passing `array()` is wrong.

Commits
-------

b8f6390 Fixed groupBy argument value in DefaultChoiceListFactoryTest
@vudaltsov vudaltsov deleted the form-default-choice-list-factory-test branch January 4, 2019 18:10
@vudaltsov
Copy link
Contributor Author

Thank you! Waiting for merges into upper branches, so I can rebase #29731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@ro0NL ro0NL ro0NL approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vudaltsov @fabpot @ro0NL @HeahDude @carsonbot
0