8000 [EventDispatcher] Fixed phpdoc on interface by samnela · Pull Request #29743 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[EventDispatcher] Fixed phpdoc on interface #29743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2019
Merged

[EventDispatcher] Fixed phpdoc on interface #29743

merged 1 commit into from
Jan 1, 2019

Conversation

samnela
Copy link
Contributor
@samnela samnela commented Jan 1, 2019
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@xabbuh xabbuh added this to the 3.4 milestone Jan 1, 2019
@fabpot
Copy link
Member
fabpot commented Jan 1, 2019

Thank you @samnela.

@fabpot fabpot merged commit 94bd28e into symfony:3.4 Jan 1, 2019
fabpot added a commit that referenced this pull request Jan 1, 2019
@fabpot
minor #29743 [EventDispatcher] Fixed phpdoc on interface (samnela)
99c9221 
This PR was merged into the 3.4 branch.

Discussion
----------

[EventDispatcher] Fixed phpdoc on interface

| Q             | A
| ------------- | ---
| Branch?       |  3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

94bd28e [EventDispatcher] Fixed phpdoc on interface
@samnela samnela deleted the fix/phpdoc-eventdispatcher-interface branch January 1, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug EventDispatcher Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@samnela @fabpot @xabbuh @carsonbot
0