8000 "ParserTest->getParserTestData()" -> only some more tests by voku · Pull Request #29723 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

"ParserTest->getParserTestData()" -> only some more tests #29723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2019
Merged

"ParserTest->getParserTestData()" -> only some more tests #29723

merged 1 commit into from
Jan 2, 2019

Conversation

voku
Copy link
Contributor
@voku voku commented Dec 29, 2018
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Added only some more tests, because I missed to add ' into my selector and then I got this error SyntaxErrorException : Expected "]", but <delimiter "[" ... so I tested my use-case directly here in the unit-tests.

@fabpot fabpot changed the base branch from master to 3.4 January 2, 2019 09:30
@fabpot fabpot force-pushed the CssSelectorArrayTest branch from d07fc5d to a95a8e4 Compare January 2, 2019 09:31
@fabpot
Copy link
Member
fabpot commented Jan 2, 2019

Thank you @voku.

@fabpot fabpot merged commit a95a8e4 into symfony:3.4 Jan 2, 2019
fabpot added a commit that referenced this pull request Jan 2, 2019
@fabpot
minor #29723 "ParserTest->getParserTestData()" -> only some more test…
bfebee8 
…s (voku)

This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29723).

Discussion
----------

"ParserTest->getParserTestData()" -> only some more tests

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Added only some more tests, because I missed to add ' into my selector and then I got this error ```SyntaxErrorException : Expected "]", but <delimiter "["``` ... so I tested my use-case directly here in the unit-tests.

Commits
-------

a95a8e4 \"ParserTest->getParserTestData()\" -> only some more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voku @fabpot @carsonbot
0