EventSubscriberInterface isn't a man #29594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Dec 13, 2018
70743d0 to
f58338e
Compare
|
Good catch, thanks @dawehner. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2018
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29594). Discussion ---------- EventSubscriberInterface isn't a man | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? |no | BC breaks? | no | Tests pass? | yes | License | MIT The documentation talks about a man, an event subscriber clearly isn't one Commits ------- f58338e EventSubscriberInterface isn't a man
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2018
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #29596). Discussion ---------- Don't use he in docs when its not needed | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? |no | BC breaks? | no | Tests pass? | yes | License | MIT The documentation talks about a man, an event subscriber clearly isn't one Similar to #29594 but in more places Commits ------- 8caab72 Don't use he in docs when its not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation talks about a man, an event subscriber clearly isn't one