[HackDay][WebProfilerBundle]Display the main template on the debug toolbar #29534
Conversation
There was a problem hiding this comment.
im a bit worried the logic is hard to reason about, by assuming that it's always one "main" render call (return $this->render('main_template.html.twig')). Whereas technically we just show the first render call and call it the main one :} im not sure that's OK.
| @@ -55,6 +55,12 @@ | |||
| <span>{{ collector.route|default('n/a') }}</span> | |||
| </div> | |||
|
|
|||
| {%- set keystemplates = profile.collectors['twig'].getTemplates|keys|default(false) -%} | |||
There was a problem hiding this comment.
this creates a dependency with the twig collector which can break, to me that implies it belongs in the twig toolbar block at least (or should be checked for; i can see you want to have it here actually).
|
I agree with @ro0NL here, the first call to render is not necessary the main template, one example is when you first render an template to send an email and then send a response. |
|
Really good idea, would save me time. 👍 |
|
Also see a related past discussion on the topic: #24236 (comment) / #24236 (review) And perhaps more ultimately: #28056 |
|
It was not done before for the reasons explained by others: there is not a "main" template concept in Symfony. And the first one might not be the "main" one. I suggest to close as having a feature that does not work for all use cases is not something we want in core. |
It's my first PR for the Symfony community.
I thought it would be useful to display the main template in the debug toolbar.
Eg :
Thanks for all and thanks for you feedbacks.
#SymfonyConHackday2018