8000 [PropertyAccess] Removed the return type phpdoc by samnela · Pull Request #29292 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyAccess] Removed the return type phpdoc #29292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2018
Merged

[PropertyAccess] Removed the return type phpdoc #29292

merged 1 commit into from
Nov 24, 2018

Conversation

samnela
Copy link
Contributor
@samnela samnela commented Nov 23, 2018
Q A
Branch? master / 4.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

ro0NL
ro0NL approved these changes Nov 23, 2018
View reviewed changes
Copy link
Contributor
@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.0 branch? Not sure we maintain it actually 🤔

@samnela samnela changed the title Removed the return type phpdoc [PropertyAccess] Removed the return type phpdoc Nov 23, 2018
@fabpot
Copy link
Member
fabpot commented Nov 24, 2018

Thank you @samnela.

@fabpot fabpot merged commit 143597a into symfony:4.1 Nov 24, 2018
fabpot added a commit that referenced this pull request Nov 24, 2018
@fabpot
minor #29292 [PropertyAccess] Removed the return type phpdoc (samnela)
eb59382 
This PR was merged into the 4.1 branch.

Discussion
----------

[PropertyAccess] Removed the return type phpdoc

| Q             | A
| ------------- | ---
| Branch?       | master / 4.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

143597a Removed the return type phpdoc
@samnela samnela deleted the remove-phpdoc branch February 2, 2019 13:29
@xabbuh xabbuh added this to the 4.1 milestone Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@sstok sstok sstok approved these changes

@ro0NL ro0NL ro0NL approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@samnela @fabpot @sstok @ro0NL @xabbuh @carsonbot
0