8000 [Form] Fixed empty data for compound date interval by HeahDude · Pull Request #29249 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fixed empty data for compound date interval #29249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2018
Merged

[Form] Fixed empty data for compound date interval #29249

merged 1 commit into from
Nov 20, 2018

Conversation

HeahDude
Copy link
Contributor
@HeahDude HeahDude commented Nov 18, 2018 •
edited
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #4715 (continuation)
License MIT
Doc PR ~

Following #29182, since this type has been introduced in Symfony 3 but with the same limitation explained in #4715.
So for consistency this needs to be fixed here as well.

@HeahDude HeahDude force-pushed the fix-empty-date-interval branch from 0a0eb62 to 38a2abc Compare November 18, 2018 12:25
@HeahDude HeahDude mentioned this pull request Nov 18, 2018
Closed
nicolas-grekas
nicolas-grekas approved these changes Nov 18, 2018
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the ::class changes are on lines that don't exist in 2.8)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 18, 2018
@nicolas-grekas
Copy link
Member

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit 38a2abc into symfony:3.4 Nov 20, 2018
nicolas-grekas added a commit that referenced this pull request Nov 20, 2018
@nicolas-grekas
bug #29249 [Form] Fixed empty data for compound date interval (HeahDude)
d0698b2 
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Fixed empty data for compound date interval

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #4715 (continuation)
| License       | MIT
| Doc PR        | ~

Following #29182, since this type has been introduced in Symfony 3 but with the same limitation explained in #4715.
So for consistency this needs to be fixed here as well.

Commits
-------

38a2abc [Form] Fixed empty data for compound date interval
@HeahDude HeahDude deleted the fix-empty-date-interval branch November 20, 2018 16:15
This was referenced Nov 26, 2018
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HeahDude @nicolas-grekas @chalasr @carsonbot
0