[HttpKernel] Fix collecting uploaded files #29183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29178 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
ro0NL
commented
Nov 12, 2018
src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php
Outdated
Show resolved
Hide resolved
ro0NL
commented
Nov 12, 2018
src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php
Outdated
Show resolved
Hide resolved
xabbuh
previously approved these changes
Nov 12, 2018
ro0NL
commented
Nov 12, 2018
src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php
Outdated
Show resolved
Hide resolved
ro0NL
commented
Nov 12, 2018
src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php
Outdated
Show resolved
Hide resolved
gharlan
approved these changes
Nov 12, 2018
|
Yes, all good now 👍 |
|
Per #29183 (comment) logic should be rercursified. status: needs work |
|
status: needs review |
javiereguiluz
approved these changes
Nov 12, 2018
xabbuh
approved these changes
Nov 12, 2018
|
is this a bug affecting only 4.2 ? |
|
@stof yes |
stof
approved these changes
Nov 12, 2018
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 13, 2018
This PR was squashed before being merged into the 4.2-dev branch (closes #29183). Discussion ---------- [HttpKernel] Fix collecting uploaded files | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29178 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- a439681 [HttpKernel] Fix collecting uploaded files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.