[BugFix][Console] Fix type hint for OutputFormatter in OutputStream constructors #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not a bug fix as existing code that extend these classes will now fail. |
|
@fabpot does the constructor enforces its signature for child classes ? I don't think so. |
|
@stof: right, I've read too fast. It's ok for constructors. |
fabpot
added a commit
that referenced
this pull request
Dec 18, 2011
Commits ------- e417153 [BugFix][Console] Fix type hint for output formatter Discussion ---------- [BugFix][Console] Fix type hint for OutputFormatter in OutputStream constructors I consider this as a bug, cause it disables ability to change formatter implementation BugFix: yes Feature addition: no Sysmfony2 test pass: yes --------------------------------------------------------------------------- by fabpot at 2011/12/18 00:23:05 -0800 It's not a bug fix as existing code that extend these classes will now fail. --------------------------------------------------------------------------- by stof at 2011/12/18 03:51:38 -0800 @fabpot does the constructor enforces its signature for child classes ? I don't think so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consider this as a bug, cause it disables ability to change formatter implementation
BugFix: yes
Feature addition: no
Sysmfony2 test pass: yes