8000 [Serializer] Allow null values when denormalizing with constructor missing data by danut007ro · Pull Request #29076 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Allow null values when denormalizing with constructor missing data #29076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2018
Merged

[Serializer] Allow null values when denormalizing with constructor missing data #29076

merged 1 commit into from
Nov 8, 2018

Conversation

danut007ro
Copy link
Contributor
Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

When using default_constructor_arguments to denormalize objects, null values for a parameter weren't processed, so instantiating was failing.

ogizanagi
ogizanagi reviewed Nov 5, 2018
View reviewed changes
@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Nov 6, 2018
@nicolas-grekas nicolas-grekas changed the title Allow null values when denormalizing with constructor missing data [Serializer] Allow null values when denormalizing with constructor missing data Nov 6, 2018
@dunglas
Copy link
Member
dunglas commented Nov 8, 2018

Thanks @danut007ro.

@dunglas dunglas merged commit 5fd0f3f into symfony:4.1 Nov 8, 2018
dunglas added a commit that referenced this pull request Nov 8, 2018
@dunglas
bug #29076 [Serializer] Allow null values when denormalizing with con…
ca5b64d 
…structor missing data (danut007ro)

This PR was squashed before being merged into the 4.1 branch (closes #29076).

Discussion
----------

[Serializer] Allow null values when denormalizing with constructor missing data

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

When using `default_constructor_arguments` to denormalize objects, `null` values for a parameter weren't processed, so instantiating was failing.

Commits
-------

5fd0f3f [Serializer] Allow null values when denormalizing with constructor missing data
@fabpot fabpot mentioned this pull request Nov 16, 2018
Merged
@fabpot fabpot mentioned this pull request Nov 26, 2018
Merged
@danut007ro danut007ro deleted the denormalizer_null branch February 14, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@fbourigault fbourigault fbourigault approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@danut007ro @dunglas @nicolas-grekas @fbourigault @ogizanagi @carsonbot
0