8000 [Messenger] If `framework.messenger.buses.X.middleware` is empty, it will be `null` by sroze · Pull Request #28980 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] If framework.messenger.buses.X.middleware is empty, it will be null #28980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2018
Merged

[Messenger] If framework.messenger.buses.X.middleware is empty, it will be null #28980

merged 1 commit into from
Oct 25, 2018

Conversation

sroze
Copy link
Contributor
@sroze sroze commented Oct 25, 2018
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28945
License MIT
Doc PR ø

Otherwise, it would fail with the following configuration:

framework:
    messenger:
        buses:
            events_bus:
                middleware:
#                    - 'some_commented_middleware'

@sroze sroze requested a review from nicolas-grekas October 25, 2018 09:47
@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Oct 25, 2018
@nicolas-grekas
Copy link
Member

Thank you @sroze.

@nicolas-grekas nicolas-grekas merged commit 91a70fc into symfony:master Oct 25, 2018
nicolas-grekas added a commit that referenced this pull request Oct 25, 2018
@nicolas-grekas
minor #28980 [Messenger] If framework.messenger.buses.X.middleware …
9c8d099 
…is empty, it will be `null` (sroze)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Messenger] If `framework.messenger.buses.X.middleware` is empty, it will be `null`

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28945
| License       | MIT
| Doc PR        | ø

Otherwise, it would fail with the following configuration:
```yaml
framework:
    messenger:
        buses:
            events_bus:
                middleware:
#                    - 'some_commented_middleware'
```

Commits
-------

91a70fc If `framework.messenger.buses.X.middleware` is empty, it will be `null`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sroze @nicolas-grekas @xabbuh @carsonbot
0