[Cache] Fix outdated CHANGELOG line #28922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,6 @@ CHANGELOG | |||
| * added support for connecting to Redis clusters via DSN | |||
| * added support for configuring multiple Memcached servers via DSN | |||
| * added `MarshallerInterface` and `DefaultMarshaller` to allow changing the serializer and provide one that automatically uses igbinary when available | |||
| * added `CacheInterface`, which provides stampede protection via probabilistic early expiration and should become the preferred way to use a cache | |||
There was a problem hiding this comment.
Or just replace "added" by "implemented" to hint about it?
There was a problem hiding this comment.
Works as well :)
Done.
nicolas-grekas
approved these changes
Oct 19, 2018
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Cache] Fix outdated CHANGELOG line | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Unless it was kept on purpose, for `Symfony\Contracts\Cache\CacheInterface` discoverability? In which case I'd add the FQCN. Commits ------- 4e89a4b [Cache] Fix outdated CHANGELOG line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless it was kept on purpose, for
Symfony\Contracts\Cache\CacheInterfacediscoverability? In which case I'd add the FQCN.